Only treat space, \t, \n, and \r as whitespace
#944
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
The `\s` character class in RegExp includes several other characters such as `\v`, `\f`, or various space variants. However, in XML only 4 characters are considered whitespace: ` ` (space), `\t`, `\n`, `\r`. This commit adjusts the pattern so that only these four are matched. It also adds whitespace characters to the formatting fixture to verify that they are formatted properly. The first two paragraphs contain tab, space, and newline characters. The carriage return character was omitted, since it's quite rare and most text editors convert it to `\n` when saving a file, so it'd likely be replaced once the fixture is edited again. The third paragraph contains all other whitespace characters that the `\s` character class includes.
These are not valid XML characters so it doesn't make sense to test them.
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
1 participant
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
This adjusts the RegExp pattern used to trim text while formatting so that it only matches the four characters that are considered whitespace in the XML standard.
I added various invisible characters to the fixture to verify the fix. Please let me know if having them there in an unescaped form is acceptable because they might trigger warnings in some code editors. (Unfortunately, I don't think there's any way to escape them in such a way that the bug is covered by tests.) The full list of non-standard invisible characters that the fixture now contains is:
Fixes #789.